[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] disk geometry



On Fri, Jun 26, 2009 at 08:23:02PM +0200, Matthias Bolte wrote:
> 2009/6/25 Daniel P. Berrange <berrange redhat com>:
> > On Wed, Jun 24, 2009 at 11:17:49AM +0200, Henrik Persson wrote:
> >> Reads the disk geometry to be able to align disk partitions on cylinder boundries.
> >> Msdos partition tables really like this stuff.
> 
> >> +    /* return the geometry of the disk and then exit */
> >> +    if(cmd == DISK_GEOMETRY) {
> >> +        printf("%d%c%d%c%d%c%",
> >> +               dev->hw_geom.cylinders, '\0',
> >> +               dev->hw_geom.heads, '\0',
> >> +               dev->hw_geom.sectors, '\0');
> >> +        return 0;
> >> +    }
> >> +
> 
> Is the trailing % intended in the format string? GCC warns about it,
> breaking -Werror compilation.

  Oops relatively clear it's unintended, thanks for raising the issue
I fixed this in CVS !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]