[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] avoid dumpXML segfault with recent Xen (3.4.0)



On Fri, Jun 26, 2009 at 08:21:39PM +0200, Daniel Veillard wrote:
>   This is basically the patch by Sascha at
>     https://bugzilla.redhat.com/show_bug.cgi?id=503254
> with a couple of cleanups. I think it's low risk, and avoid a crash so I
> commited it.
> Basically ths SXPR syntax changed from (type vnc) to (vnc 1) for VNC
> vfb devices, and assuming something similar for sdl. The code checks
> first for type then backoff for vnc/sdl  so I think this is backward
> compatible.

ACK, this is the sort of thing we should definitely add another
test data file for, to ensure we don't regress in the future.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]