[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] small fixes in storage_conf.c



On Mon, Mar 02, 2009 at 10:13:11AM +0100, Jim Meyering wrote:
> Ryota Ozaki wrote:
> > These patches fix:
> > - missing VIR_FREE for the return value of virXPathString
> > - wrong error message "missing owner element" where should be "missing
> > group element"
> 
> Thank you!
> Both of those are fine.

 Agreed, I was about to commit them myself !

> I'll apply them today.

  please go ahead !

> FYI, looking at the first one, I spotted another problem.
> Since strtol dereferences its 2nd parameter when it's non-NULL,
> it must always be initialized.
> 
> I'll post that fix separately.

  okay if it's trivial please commit, as I would like to make a 0.6.1
release soon, hopefully today

  thanks,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]