[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Remove qemudLog() macro, use logging.h instead



On Tue, Mar 03, 2009 at 10:48:27AM +0100, Jim Meyering wrote:
> Daniel P. Berrange wrote:
> > The qemudLog() macro just spews its messages to stderr. This patch changes
> > it to use the proper logging.h APIs, so the output channel is configurable
> > in the expected way.
> 
> Looks good.
> 
> Considering the preceding comment, and since you didn't mention
> this sole WARN->ERROR change, I wonder if it was deliberate:
> 
> > diff --git a/src/qemu_conf.c b/src/qemu_conf.c
> ...
> >      /* Check & log unexpected exit status, but don't fail,
> >       * as there's really no need to throw an error if we did
> >       * actually read a valid version number above */
> >      if (WEXITSTATUS(status) != 0) {
> > -        qemudLog(QEMUD_WARN,
> > -                 _("Unexpected exit status '%d', qemu probably failed"),
> > -                 WEXITSTATUS(status));
> > +        VIR_ERROR(_("Unexpected exit status '%d', qemu probably failed"),
> > +                  WEXITSTATUS(status));
> >      }

That's a mistake

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]