[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix test driver domain save



On Fri, Mar 13, 2009 at 05:07:52PM -0400, Cole Robinson wrote:
> Saving a domain via the test driver currently locks up, since the save
> command is calling out to another public driver method. The attached
> patch fixes this.

ACK.  I should add this 'public API calls public API' scenario to the CIL
lock checking program I wrote.

Daniel

> diff --git a/src/test.c b/src/test.c
> index 226fe2e..2be874f 100644
> --- a/src/test.c
> +++ b/src/test.c
> @@ -1172,8 +1172,6 @@ cleanup:
>      return ret;
>  }
>  
> -static char *testDomainDumpXML(virDomainPtr domain, int flags);
> -
>  #define TEST_SAVE_MAGIC "TestGuestMagic"
>  
>  static int testDomainSave(virDomainPtr domain,
> @@ -1196,7 +1194,10 @@ static int testDomainSave(virDomainPtr domain,
>          goto cleanup;
>      }
>  
> -    xml = testDomainDumpXML(domain, 0);
> +    xml = virDomainDefFormat(domain->conn,
> +                             privdom->def,
> +                             VIR_DOMAIN_XML_SECURE);
> +
>      if (xml == NULL) {
>          virReportSystemError(domain->conn, errno,
>                               _("saving domain '%s' failed to allocate space for metadata"),

> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]