[libvirt] [PATCH 1/1] Add SCSI pool support.

[Dave Allan]

Daniel P. Berrange wrote:
> On Thu, Mar 26, 2009 at 05:55:48PM -0400, David Allan wrote:
>> It does not attempt to add a volume if it cannot find a stable 
>> path for a particular LU, for example, if the user specifies a 
>> target path by-id and the LU is one path of a multipath device.
> 
> This will cause  a regression in current behaviour - if a device
> does not have a stable path, the semantics are that we just expose
> the raw path /dev/sdXX.

I see this as a bug fix, not a regression.  Using an unstable path is 
almost certain to cause data loss if the system is operated for any 
length of time.  Any addition or removal of a single LU visible to the 
VM host will cause reordering of the unstable paths following reboot, 
and one VM will now be using another VM's disk, or worse, if one VM uses 
a stable path and one uses an unstable path, both VMs will use the same 
disk simultaneously.

Dave