[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2]: Remove getURI internal driver call



Daniel P. Berrange wrote:
> On Tue, Mar 31, 2009 at 11:41:58AM +0200, Daniel Veillard wrote:
>> On Mon, Mar 30, 2009 at 02:10:13PM +0200, Chris Lalancette wrote:
>>> This patch removes the internal getURI() driver callback.  It was *never*
>>> overridden by any of the drivers, so it seems kind of pointless (I even checked
>>> the "in-progress" VirtualBox, OpenNebula, and Power Hypervisor drivers).  In
>>> addition, the code to actually use it in src/libvirt.c:virConnectGetURI() was
>>> buggy; if a driver did decide to have their own callback, then their callback
>>> would be called, and then immediately overwritten by the generic stuff.  This
>>> wouldn't do what the driver expected, and would also probably leak memory.  Just
>>> rip out this internal callback; if a future driver ever needs it, we can add it
>>> back in.
>>   Agreed if the entry point is not used let's remove it, ACK !
> 
> ACK. It was used in the past, but I guess I made it unneccessary when I
> patched virConnectPtr to include a full xmlURIPtr object.

Ah, understood.  Committed now.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]