[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] change permissions of directories in cgroups



Quoting Ryota Ozaki (ozaki ryota gmail com):
> Hi,
> 
> This patch creates a directory in cgroups with an ordinary
> permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x).
> 
> I guess 0655 is not expected and just a mistake, or is
> there a special reason?

Haha, that sure seems like a mistake.  Good catch.

> Thanks,
>   ozaki-r
> 
> Signed-off-by: Ryota Ozaki <ozaki ryota gmail com>

Acked-by: Serge Hallyn <serue us ibm com>

thanks,
-serge

> >From 4829855bc0baa3c75806f106bc0e54eb1da75eea Mon Sep 17 00:00:00 2001
> From: Ryota Ozaki <ozaki ryota gmail com>
> Date: Fri, 8 May 2009 03:23:50 +0900
> Subject: [PATCH] change permissions of directories in cgroups
> 
> This patch creates a directory in cgroups with an ordinary
> permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x).
> ---
>  src/cgroup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/cgroup.c b/src/cgroup.c
> index d1d44a2..50517e2 100644
> --- a/src/cgroup.c
> +++ b/src/cgroup.c
> @@ -436,7 +436,7 @@ static int virCgroupMakeGroup(const char *name)
>          virCgroupFree(&root);
> 
>          if (access(path, F_OK) != 0) {
> -            if (mkdir(path, 0655) < 0) {
> +            if (mkdir(path, 0755) < 0) {
>                  rc = -errno;
>                  VIR_FREE(path);
>                  break;
> -- 
> 1.6.0.6
> 
> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]