[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] Public API for new virInterface* functions, which facilitate



On Fri, May 08, 2009 at 01:52:23PM -0400, Laine Stump wrote:
> From: Laine Stump <laine redhat com>
> 
> ---
>  include/libvirt/libvirt.h    |   84 ++++++++++++++++++++++++++++++++++++++++++
>  include/libvirt/libvirt.h.in |   84 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 168 insertions(+), 0 deletions(-)

> +
> +char *                  virInterfaceGetXMLDesc    (virInterfacePtr interface,
> +                                                   int flags);
> +virInterfacePtr         virInterfaceDefineXML     (virConnectPtr conn,
> +                                                   const char *xmlDesc,
> +                                                   int flags);
> +int                     virInterfaceCreate        (virInterfacePtr interface,
> +                                                   int flags);
> +int                     virInterfaceDestroy       (virInterfacePtr interface,
> +                                                   int flags);

Oh, one very minor point - can you change these to 'unsigned int', since that's
what we now prefer to use for flags (yes, some existing APIs are bad in this
respect)

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]