[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/7] Storage driver implementation for CreateXMLFrom



On Mon, May 04, 2009 at 01:43:00PM -0400, Cole Robinson wrote:
> There is some funkiness here, since we are either dealing with 2 different
> pools (which means validation x 2) or the same pool, where we have to be
> careful not to deadlock.

Ahhh, tricky stuff.

> +
> +    newvol->building = 1;
> +    buildret = backend->buildVolFrom(obj->conn, newvol, origvol, flags);
> +    newvol->building = 0;
> +    newvol = NULL;

I'm wondering if we should also take care to mark origvol->building as
non-zero, to incidate that it is in use too.  Regardless though, we
need to ensure buildVolFrom is safe against someone deleting the file 
from the filesystem behind our back

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]