[libvirt] PATCH: Fix QEMU arg detection for kvm >= 85

Daniel Veillard veillard at redhat.com
Mon May 11 14:13:57 UTC 2009


On Fri, May 08, 2009 at 11:39:28AM +0100, Daniel P. Berrange wrote:
> The -help output from KVM >= 85 is now large than we expected. This patch
> increases the buffer from 8k to 64k when reading help. It also provides
> more detailed error messages should something go wrong in the future.
> 
> Two examples of improved error reporting
> 
> # virsh -c qemu:///system start VirtTest
> error: Failed to start domain VirtTest
> error: Unable to read QEMU help output: Value too large for defined data type
> 
> # virsh -c qemu:///system start VirtTest
> error: Failed to start domain VirtTest
> error: internal error cannot parse QEMU version number in 'QEMU PC emulator version 0.9.1 (kvm-79), Copyright (c) 2003-2008 Fabrice Bellard'

  ACK, a rather annoying bug !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/




More information about the libvir-list mailing list