[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Support for vrdp/sdl/gui while defining a machine



> This wasn't exactly what I anticipated. It intended that it should report
> the error *and* return as an error to the caller, rather than carrying on.

hmm.. I thought it more like handling NULL returns from strdup.

> That said, I notice that none of the existing code we have committed for
> VirtualBox driver deals with OOM on strdup() calls, so this patch is not
> making things any worse. Thus I think we can commit these patches and
> fix all the strdup calls in one go, later.


oops, Sorry this seems to be pretty big slip, yes will try to fix all of them 
but help is definitely appreciated.

Also if strdup() is going to be handle like alloc/VIR_ALLOC way, then i would 
wait for that and then do the changes.

Regards,
Pritesh.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]