[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/7] Add public API stubs for virStorageVolCreateXMLFrom



On Mon, May 04, 2009 at 01:42:56PM -0400, Cole Robinson wrote:
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  include/libvirt/libvirt.h    |    4 +++
>  include/libvirt/libvirt.h.in |    4 +++
>  src/driver.h                 |    6 ++++
>  src/libvirt.c                |   61 ++++++++++++++++++++++++++++++++++++++++-
>  src/libvirt_public.syms      |    5 +++
>  5 files changed, 78 insertions(+), 2 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h
> index 30f559d..b1e45e4 100644
> --- a/include/libvirt/libvirt.h
> +++ b/include/libvirt/libvirt.h
> @@ -1047,6 +1047,10 @@ const char*             virStorageVolGetKey             (virStorageVolPtr vol);
>  virStorageVolPtr        virStorageVolCreateXML          (virStoragePoolPtr pool,
>                                                           const char *xmldesc,
>                                                           unsigned int flags);
> +virStorageVolPtr        virStorageVolCreateXMLFrom      (virStoragePoolPtr pool,
> +                                                         const char *xmldesc,
> +                                                         unsigned int flags,
> +                                                         virStorageVolPtr clonevol);

  just one nitpick, we usually keep flags at the end of the list of
arguments, so I would just swap flags and clonevol

> diff --git a/src/driver.h b/src/driver.h
> index c357b76..ff12ada 100644
> --- a/src/driver.h
> +++ b/src/driver.h
> @@ -586,6 +586,11 @@ typedef char *
>  typedef char *
>      (*virDrvStorageVolGetPath)               (virStorageVolPtr vol);
>  
> +typedef virStorageVolPtr
> +    (*virDrvStorageVolCreateXMLFrom)         (virStoragePoolPtr pool,
> +                                              const char *xmldesc,
> +                                              unsigned int flags,
> +                                              virStorageVolPtr clone);

  same here, even if it's the internal one and less of a problem.

Except for this ACK, 

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]