[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Enable migration with QEMU >= 0.10.0



Daniel P. Berrange schrieb:
The KVM migration code was added to QEMU for the 0.10.0 release, so we should enable this in libvirt now.

Daniel

Hello

Why is in qemu_conf.c caps initialized with 0 for offlineMigrate and liveMigrate?

qemu_conf.c line 364 ff

virCapsPtr qemudCapsInit(void) {
struct utsname utsname;
virCapsPtr caps;
int i;

/* Really, this never fails - look at the man-page. */
uname (&utsname);

if ((caps = virCapabilitiesNew(utsname.machine,
0, 0)) == NULL)

virsh capabilities does not return <migration_features>
Is this a bug or doesn't it matter and is a mere cosmetical issue?
in virCapabilitiesNew() in capabilities.c line 51 and 52 caps->host.offlineMigrate and caps->host.liveMigrate is so set to 0. Should this be fixed and both set to 1 when setting caps with virCapabilitiesNew because if i do so i get the

with:
if ((caps = virCapabilitiesNew(utsname.machine,
0, 0)) == NULL)

[root rr010 ~]# virsh capabilities
<capabilities>

<host>
<cpu>
<arch>x86_64</arch>
</cpu>
<topology>
<cells num='1'>
<cell id='0'>
<cpus num='4'>
<cpu id='0'/>
<cpu id='1'/>
<cpu id='2'/>
<cpu id='3'/>
</cpus>
</cell>
</cells>
</topology>
</host>

with:
if ((caps = virCapabilitiesNew(utsname.machine,
1, 1)) == NULL)

[root rr016 ~]# virsh capabilities
<capabilities>

<host>
<cpu>
<arch>x86_64</arch>
</cpu>
<migration_features>
<live/>
</migration_features>
<topology>
<cells num='1'>
<cell id='0'>
<cpus num='2'>
<cpu id='0'/>
<cpu id='1'/>
</cpus>
</cell>
</cells>
</topology>
</host>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]