[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use virAsprintf, rather than VIR_ALLOC + strcpy + strcat



On Mon, May 18, 2009 at 01:57:49PM -0400, Cole Robinson wrote:
> ---
>  qemud/remote.c                |    9 ++++-----
>  src/remote_internal.c         |    7 ++-----
>  src/storage_backend.c         |    9 +++------
>  src/storage_backend_fs.c      |   29 +++++++++++++----------------
>  src/storage_backend_logical.c |    9 ++++-----
>  src/test.c                    |   18 ++++++------------
>  6 files changed, 32 insertions(+), 49 deletions(-)

ACK, good to get rid of these. Might be fun to add a 'make syntax-check' rule
to detect 2 or more lines in sequence using strcat/strcpy.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]