[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem



Apologies for not responding. I've come down with a cold
(not flu) for several days...

On Tue, May 19, 2009 at 10:34 PM, Daniel Veillard <veillard redhat com> wrote:
> On Mon, May 11, 2009 at 06:01:07PM +0900, Ryota Ozaki wrote:
>> Hi,
>> I've updated the patch. The change includes support for multiple mount
>> points of cgroups that I didn't cope with in the previous patch.
>>
>> Through the work, I found a bit messy problem. Current lxc controller writes
>> pid in a 'tasks' file multiple times if one mount point has multiple subsystems.
>> It is bad because the first write changes the cgroups path of a controller, and
>> then the second write points a missing file like
>> $CGROUPS_MOUNTPOINT/<path_to_domain>/<path_to_domain>/tasks where
>> the correct file is $CGROUPS_MOUNTPOINT/<path_to_domain>/tasks.
>> I did workaround this problem with a tricky way by truncating the
>> duplicated path.
>> We probably need a more feasible solution.
>>
>> Note that this patch intends a proof of concept to be clear the correct way
>> to go and thus it remains a couple of awkward codes. Of course the codes
>> should be removed if we find the correct way.
>
>  Just to make sure, this is not ready, right ?
> We freeze for libvirt-0.6.4 this week-end,

Yes, not completed yet, but continue working on. So I
hope to be in time.

  ozaki-r

>
> Daniel
>
> --
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]