[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2



> On Wed, May 20, 2009 at 11:32:18AM +0100, Daniel P. Berrange wrote:
> > On Wed, Apr 22, 2009 at 05:03:41PM +0200, "Abel M?guez 
> Rodr?guez" wrote:
> > > Hi all,
> > > 
> > > Here is the One driver & patches for the current git's 
> master commit "9e9527 - Remove stale QEMU pidfiles".
> > > 
> > > [PATCH 1/2] Patch to be applied to libvirt-0.6.2 sources and 
> building files.
> > > [PATCH 2/2] Driver source code.
> > > 
> > > Thanks for all the comments about the patches.
> > > We waited for the libvirt's release to update the driver's 
> structure to 0.6.2 and apply the improvements. 
> > > Here is a short list of the main changes applied:
> > > 
> > > - Included driver's files in a different directory 
> "src/opennebula"> > 
> > > - Added Capabilities "virCapabilitiesAddGuest" for "x86_64" 
> and "i686" guests and used "one" as hypervisor at 
> "virCapabilitiesAddGuestDomain".> > 
> > > - Instead creating a temporal file to send the VM definition 
> we have updated the API we were using to being able to do 
> everything in memory, so making use of "virBuffer" to create the 
> VM definition Template.
> > > 
> > > - Added previously unsupported features to the ONE Template, 
> other types of disks and graphics (vnc,sdl) settings.
> > > 
> > > - Fixed up warnings at compilation and make 'syntax-check' 
> test passed.
> > 
> > 
> > Sorry for the delay in reviewing this patch. It all looks alot 
> better> now, and pretty close to ready for commit.
> > 
> > There is just one question I have though - when the driver initially
> > starts up, there does not seem to be any code to populate the 
> list 
> > of existing running VMs. ie, nothing loads data into driver->domains
> > So it only appears to remember domains you've started  
> via libvirt
> > since opening the connection. 
> > 
> > My inclination at this point is to merge the driver and then 
> we can do 
> > incremental patches to fix further problems as they arise.
> 
>   Agreed, unless Abel has a newer version to submit, I'm 
> inclined to
> push it before the end of the week,
> 

Hi,
This version is right to submit. 
I agree, after merged, any further modification needed will be solved by patches.
Related with Daniel's question, we will submit a patch to populate the running VM list at libvirt's startup.

Cheers,



Abel Miguez Rodriguez
----
 Distributed System Architecture Group  
 (http://dsa-research.org)

 GridWay, http://www.gridway.org
 OpenNEbula, http://www.opennebula.org





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]