[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Ensure filename/funcname/linenr gets passed to error func



On Thu, May 21, 2009 at 04:16:31PM +0100, Daniel P. Berrange wrote:
> The current virRaiseError() function does not accept any information about
> these source location of the error. The various virReportSystemError and
> virReportOOMError wrappers all collect this info, but then discard it.

  Ah, okay, now I understand,

> This patch turns virRaiseError  into virRaiseErrorFull() and adds params
> for linenr, filename & funcname, and then adds a macro providing the
> original virRaiseError() API contract, and collecting source location
> info. The other wrappers are changed to call virRaiseErrorFull() directly
> preserving their source location data. Finally the source location is
> passed into the virLogMessage call.
> 
> This should address the issue that Mattias mentioned in the VMWare driver
> thread.

  ACK, patch looks fine !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]