[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] Detect availability of QEMU -chardev command line option



On Tue, Nov 03, 2009 at 04:07:39PM +0000, Matthew Booth wrote:
> ---
>  src/qemu/qemu_conf.c |    2 ++
>  src/qemu/qemu_conf.h |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 4fd158c..e5d19ef 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -875,6 +875,8 @@ static unsigned int qemudComputeCmdFlags(const char *help,
>          flags |= QEMUD_CMD_FLAG_PCIDEVICE;
>      if (strstr(help, "-mem-path"))
>          flags |= QEMUD_CMD_FLAG_MEM_PATH;
> +    if (strstr(help, "-chardev"))
> +        flags |= QEMUD_CMD_FLAG_CHARDEV;
>  
>      if (version >= 9000)
>          flags |= QEMUD_CMD_FLAG_VNC_COLON;
> diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h
> index f9a970f..4aa764b 100644
> --- a/src/qemu/qemu_conf.h
> +++ b/src/qemu/qemu_conf.h
> @@ -71,6 +71,7 @@ enum qemud_cmd_flags {
>      QEMUD_CMD_FLAG_DRIVE_SERIAL  = (1 << 19), /* -driver serial=  available */
>      QEMUD_CMD_FLAG_XEN_DOMID     = (1 << 20), /* -xen-domid (new style xen integration) */
>      QEMUD_CMD_FLAG_MIGRATE_QEMU_UNIX = (1 << 21), /* Does qemu support unix domain sockets for migration? */
> +    QEMUD_CMD_FLAG_CHARDEV       = (1 << 22), /* Is the new -chardev arg available */
>  };

OK ... We assume therefore that qemu contains support for the
relatively new -chardev feature?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]