[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/15] Move code for low level QEMU monitor interaction into separate file



On Wed, Nov 04, 2009 at 12:09:39PM +0100, Daniel Veillard wrote:
> On Tue, Nov 03, 2009 at 02:49:58PM -0500, Daniel P. Berrange wrote:
> > The qemu_driver.c code should not contain any code that interacts
> > with the QEMU monitor at a low level. A previous commit moved all
> > the command invocations out. This change moves out the code which
> > actually opens the monitor device.
> 
> [...]
> > +static int
> > +qemuMonitorCheckPrompt(virDomainObjPtr vm,
> > +                       const char *output,
> > +                       int fd)
> > +{
> > +    if (strstr(output, "(qemu) ") == NULL)
> > +        return 1; /* keep reading */
> 
>   just wondering, wouldn't it be safer to try to find the previous end
>   of line too ?

This particular piece of code is deleted in a later patch in the series

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]