[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Prevent initializing ebtables if disabled in qemu.conf



On Tue, Nov 10, 2009 at 08:34:17PM -0500, Cole Robinson wrote:
> On 11/10/2009 06:32 PM, Ryota Ozaki wrote:
> > * src/qemu/qemu_conf.c: don't initialize ebtables if
> >   disabled
> > ---
> >  src/qemu/qemu_conf.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> > index 28567b2..5f492dd 100644
> > --- a/src/qemu/qemu_conf.c
> > +++ b/src/qemu/qemu_conf.c
> > @@ -322,7 +322,7 @@ int qemudLoadDriverConfig(struct qemud_driver *driver,
> >  
> >      p = virConfGetValue (conf, "mac_filter");
> >      CHECK_TYPE ("mac_filter", VIR_CONF_LONG);
> > -    if (p) {
> > +    if (p && p->l) {
> >          driver->macFilter = p->l;
> >          if (!(driver->ebtables = ebtablesContextNew("qemu"))) {
> >              driver->macFilter = 0;
> 
> ACK

  I concur, applied :-),

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]