[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Fix cleanup when state driver init fails



On Fri, Nov 13, 2009 at 12:21:10PM +0000, Daniel P. Berrange wrote:
> * daemon/libvirtd.c: Fix incorrect goto label causing cleanup to
>   be missed when state driver init fails
> ---
>  daemon/libvirtd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index ef07460..1caa4ce 100644
> --- a/daemon/libvirtd.c
> +++ b/daemon/libvirtd.c
> @@ -3153,7 +3153,7 @@ int main(int argc, char **argv) {
>       * seriously delay OS bootup process */
>      if (virStateInitialize(server->privileged) < 0) {
>          VIR_ERROR0("Driver state initialization failed");
> -        goto error;
> +        goto shutdown;
>      }
>  
>      /* Start accepting new clients from network */

  ACK, having a separate thread run the cleanup makes things a bit
  harder,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]