[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Pull schedular affinity code out into a separate module



On Mon, Nov 16, 2009 at 04:49:29PM +0000, Daniel P. Berrange wrote:
> * src/Makefile.am: Add processinfo.h/processinfo.c
> * src/util/processinfo.c, src/util/processinfo.h: Module providing
>   APIs for getting/setting process CPU affinity
> * src/qemu/qemu_driver.c: Switch over to new APIs for schedular
>   affinity
> * src/libvirt_private.syms: Export virProcessInfoSetAffinity
>   and virProcessInfoGetAffinity to internal drivers
> ---
>  src/Makefile.am          |    4 +-
>  src/libvirt_private.syms |    5 ++
>  src/qemu/qemu_driver.c   |   73 +++++++++++++--------------------
>  src/util/processinfo.c   |  101 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/processinfo.h   |   37 +++++++++++++++++
>  5 files changed, 175 insertions(+), 45 deletions(-)
>  create mode 100644 src/util/processinfo.c
>  create mode 100644 src/util/processinfo.h
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> @@ -268,7 +269,8 @@ NODE_DEVICE_DRIVER_HAL_SOURCES =				\
>  		node_device/node_device_hal.h
>  
>  NODE_DEVICE_DRIVER_UDEV_SOURCES =				\
> -		node_device/node_device_udev.c
> +		node_device/node_device_udev.c			\
> +		node_device/node_device_udev.h
>  
>  
>  #########################

  Can you commit that separately as this is a bug fix for 0.7.3 in any
case ?

> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index c473d49..e880c2e 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -374,6 +374,11 @@ pciDeviceListUnlock;
>  pciDeviceListSteal;
>  
>  
> +# processinfo.h
> +virProcessInfoSetAffinity;
> +virProcessInfoGetAffinity;

  On one hand this is a bug fix and will affect testers, on the other hand
this is also a relatively heavy cleanup, but it's probably a good idea
to commit this before 0.7.3

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]