[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Xen: Add support for interface model='xenpv'



> > A possible addition to this would be to force type=ioemu for all other
> > models which would result in only emulated network device to be provided
> > for an HVM guest on xen newer then XEND_CONFIG_MAX_VERS_NET_TYPE_IOEMU.
> > No type would be configured when model is missing in domains XML.
> > If you think this is a good idea, I'll prepare a second version of the
> > patch.
> 
> Yes, but a slight variation - we need to maintain reasonable back
> compatability so there are 3 cases to support
> 
>  - No model - use current behaviour which lets it setup both
>  - xenpv  - use only PV nic
>  - other model - use the requested emulated nic

Yes, that was my intention.

> Can you add a couple of test data files for this since its quite a
> complex area of conversion - you'll see we've already got the 
> sexpr2xmltest.c and xml2sexprtest.c and xmconfigtest.c for Xen

Will do.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]