[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix various breakages in qemu "virsh dump"



On Fri, Nov 27, 2009 at 06:33:13PM +0100, Paolo Bonzini wrote:
> 1) qemuMigrateToCommand uses ">>" so we have to truncate the file
> before starting the migration;
> 
> 2) the command wasn't updated to chown the driver and set/restore
> the security lavels;
> 
> 3) the VM does not have to be resumed if migration fails;
> 
> 4) the file is not removed when migration fails.
> 
> * src/qemu/qemu_driver.c (qemuDomainCoreDump): Truncate file before
> dumping, set/restore ownership and security labels for the file.
> ---
>  src/qemu/qemu_driver.c |   48 +++++++++++++++++++++++++++++++++++++++++++++---
>  1 files changed, 45 insertions(+), 3 deletions(-)


ACK, looks good.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]