[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Support a new peer-to-peer migration mode & public API



On 09/17/2009 07:25 PM, Daniel P. Berrange wrote:
+    if (flags&  VIR_MIGRATE_PEER2PEER) {
+        if (VIR_DRV_SUPPORTS_FEATURE (domain->conn->driver, domain->conn,
+                                      VIR_DRV_FEATURE_MIGRATION_P2P)) {
+            char *duri = NULL;

Is there a reason why you shouldn't try a VIR_MIGRATE_PEER2PEER if dconn is NULL, rather than having a separate flag? If I read the code correctly, this would make virDomainMigrateToURI unnecessary.

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]