[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Support a new peer-to-peer migration mode & public API



On Thu, Oct 01, 2009 at 03:57:13PM +0200, Paolo Bonzini wrote:
> On 09/17/2009 07:25 PM, Daniel P. Berrange wrote:
> >+    if (flags&  VIR_MIGRATE_PEER2PEER) {
> >+        if (VIR_DRV_SUPPORTS_FEATURE (domain->conn->driver, domain->conn,
> >+                                      VIR_DRV_FEATURE_MIGRATION_P2P)) {
> >+            char *duri = NULL;
> 
> Is there a reason why you shouldn't try a VIR_MIGRATE_PEER2PEER if dconn 
> is NULL, rather than having a separate flag?  If I read the code 
> correctly, this would make virDomainMigrateToURI unnecessary.

If 'dconn' is NULL, it is impossible to create a 'virDomainPtr' on the
destination connection, which is required as the return value of the
virDomainMigrate function to indicate success.

Hence we need a new virDomainMigrateToURI method which returns an 'int'
status code, instead of virDomainPtr

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]