[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH 3/6] add the ebtables wrapper to network driver



On Fri, Oct 02, 2009 at 03:48:21PM +0200, Gerhard Stenzel wrote:
> This patch adds the ebtables wrapper to the network driver.
> 
> Signed-off-by: Gerhard Stenzel <gerhard stenzel de ibm com>
> ---
> 
>  src/conf/network_conf.h     |   10 ++
>  src/libvirt_private.syms    |   26 ++++++
>  src/network/bridge_driver.c |  179 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 215 insertions(+), 0 deletions(-)

IMHO, this code does not belong in the virNetwork apis / driver
because that restricts its usefulness to guests using the virtual
network configuration mode, ignoring any guests using bridged
configs which are arguably far more important since those have
ability to spoof MACs on the real LAN, not merely local machine.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]