[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/7] lxc: add augeas support for config file



On Mon, Oct 5, 2009 at 9:55 PM, Daniel P. Berrange <berrange redhat com> wrote:
> On Sun, Oct 04, 2009 at 03:29:26PM -0400, Amy Griffis wrote:
>> I've attempted to add augeas support for lxc.conf based on qemu.conf.
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 73bbb70..7e3abab 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -35,6 +35,12 @@ mod_LTLIBRARIES =
>>  confdir = $(sysconfdir)/libvirt
>>  conf_DATA =
>>
>> +augeasdir = $(datadir)/augeas/lenses
>> +augeas_DATA =
>> +
>> +augeastestdir = $(datadir)/augeas/lenses/tests
>> +augeastest_DATA =
>> +
>>  # These files are not related to driver APIs. Simply generic
>>  # helper APIs for various purposes
>>  UTIL_SOURCES =                                                       \
>> @@ -429,11 +435,8 @@ libvirt_driver_qemu_la_SOURCES = $(QEMU_DRIVER_SOURCES)
>>
>>  conf_DATA += qemu/qemu.conf
>>
>> -augeasdir = $(datadir)/augeas/lenses
>> -augeas_DATA = qemu/libvirtd_qemu.aug
>> -
>> -augeastestdir = $(datadir)/augeas/lenses/tests
>> -augeastest_DATA = qemu/test_libvirtd_qemu.aug
>> +augeas_DATA += qemu/libvirtd_qemu.aug
>> +augeastest_DATA += qemu/test_libvirtd_qemu.aug
>>
>>  check-local:
>>       test -x '$(AUGPARSE)' \
>
>
> It'd be good to add to the check-local:  test here, so the config
> file parser is tested as part of 'make check'

Oh, the check-local is corrupted.

check-local:
        test -x '$(AUGPARSE)' \
          && '$(AUGPARSE)' -I $(srcdir) $(srcdir)/test_libvirtd_qemu.aug || :

We ought to append qemu/ to $(srcdir).

  ozaki-r

>
> Regards,
> Daniel
> --
> |: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
> |: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
>
> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]