[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] allow non-zero success values from a domain's MigratePerform



On Thu, Oct 01, 2009 at 08:18:32PM +0200, Paolo Bonzini wrote:
> A return code of say 1 from Perform is currently considered an error,
> but it could also be passed simply to Finish.  This makes the v2
> protocol much more powerful.
> 
> * src/remote/remote_protocol.x (remote_domain_migrate_perform_ret): New.
> * src/qemu/qemu_driver.c (qemudDomainMigrateFinish2): Succeed if
> qemudDomainMigratePerform returned a non-zero but positive value.
> 
> * daemon/remote.c (remoteDispatchDomainMigratePerform): Adjust for
> remote_domain_migrate_perform_ret.
> * daemon/remote_dispatch_prototypes.h: Regenerate.
> * daemon/remote_dispatch_ret.h: Regenerate.
> * daemon/remote_dispatch_table.h: Regenerate.
> 
> * src/remote/remote_driver.c (remoteDomainMigratePerform): Adjust for
> remote_domain_migrate_perform_ret.
> * src/remote/remote_protocol.c: Regenerate.
> * src/remote/remote_protocol.h: Regenerate.

  Sounds fine by me, but I wonder about the change of semantic for
  client server not at the same version level. Could you explain what
might happen in those case ?

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]