[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/6] restore correctly the state of the VM upon migration



On Wed, Oct 07, 2009 at 03:14:18PM +0200, Paolo Bonzini wrote:
> On 10/07/2009 03:03 PM, Daniel Veillard wrote:
>>   NACK ! an error in migration should not result in a dead daemon
>> assert/exit forbidden even in error handling paths.
>
> I have no problem removing the assertion, however notice that I added it  
> simply to match
>
>     vm->state = migrateFrom ? VIR_DOMAIN_PAUSED : VIR_DOMAIN_RUNNING;
>
> in qemudStartVMDaemon.  It is not an error handling path.

  Okay, but still, we should not call exit even if something might be
slightly broken :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]