[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/7] lxc: initialize logging configuration



On Wed, Oct 07, 2009 at 03:36:18PM -0400, Amy Griffis wrote:
> Daniel P. Berrange wrote:  [Mon Oct 05 2009, 08:52:20AM EDT]
> > ACK, although it'd need a small change for my suggested API contract
> > change in your previous patch in the series
> 
> Updated for API change...
> 
> Before launching the lxc controller, have the lxc driver query the log
> settings and setup envp[]. This provides the advantage of honoring the
> actual log configuration instead of only what had been set in the
> environment. The lxc controller now simply has to call
> virLogSetFromEnv().

  Okay, makes sense, looks fine, I just corrected a white space issue
before applying,

  thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]