[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/7] lxc: add augeas support for config file

On Tue, Oct 06, 2009 at 01:10:29AM -0400, Amy Griffis wrote:
> Ryota Ozaki wrote:  [Tue Oct 06 2009, 12:01:30AM EDT]
> >On Mon, Oct 5, 2009 at 9:55 PM, Daniel P. Berrange <berrange redhat com> wrote:
> >> It'd be good to add to the check-local:  test here, so the config
> >> file parser is tested as part of 'make check'
> >
> >Oh, the check-local is corrupted.
> >
> >check-local:
> >        test -x '$(AUGPARSE)' \
> >          && '$(AUGPARSE)' -I $(srcdir) $(srcdir)/test_libvirtd_qemu.aug || :
> >
> >We ought to append qemu/ to $(srcdir).
> >
> >  ozaki-r
> I just caught that too. I think this updated patch should fix it. I
> changed the rule slightly so it won't fail when there's no $(AUGPARSE)
> but it will fail if it doesn't parse correctly. I think that's what
> you would want.

  Hum, the patch didn't want to apply for some reasons, anyway this
is pushed now, double check the whole serie should be on git head !

 thanks a lot !


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]