[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] LXC fix rc handling in lxcVmStart



Ryota Ozaki wrote:
> Hi,
> 
> In lxcVmStart we have to set rc = -1 before jumping to the cleanup
> code when a local procedure call fails and the rc is overwritten,
> however, some codes don't observe the rule and so invalid cleanups
> are likely to happen.
> 
> A simple solution for the defect is to add rc = -1 before every
> jumping if needed, however, IMHO, we first should not reuse rc for
> another purpose rather than the return value of lxcVmStart. Instead
> the patch introduces yet another variable for storing only the
> return value of the local procedure calls. By doing so, we don't
> need to care about resetting rc anymore.

Yes, that's a much better way to do it.

ACK

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]