[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Take domain type into account when looking up default machine



On Mon, Oct 12, 2009 at 11:00:31AM +0100, Mark McLoughlin wrote:
> If one has e.g.
> 
>   <guest>
>     <os_type>hvm</os_type>
>     <arch name='x86_64'>
>       <wordsize>64</wordsize>
>       <emulator>/usr/bin/qemu-system-x86_64</emulator>
>       <machine>pc-0.11</machine>
>       <machine canonical='pc-0.11'>pc</machine>
>       <machine>pc-0.10</machine>
>       <machine>isapc</machine>
>       <domain type='qemu'>
>       </domain>
>       <domain type='kvm'>
>         <emulator>/usr/bin/kvm</emulator>
>         <machine>pc</machine>
>         <machine>isapc</machine>
>       </domain>
>     </arch>
>   </guest>
> 
> and start a guest with:
> 
>   <domain type='kvm'>
>     ...
>     <os>
>       <type arch='x86_64'>hvm</type>
>       ...
>     </os>
>   </domain>
> 
> then the default machine type should be 'pc' and not 'pc-0.11'

  Okay, the patch looks strangely formatted on my screen but I assume
  it's just a rendering problem. The principle and code looks fine to me

   ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]