[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/10] storage: Fix generating iscsi 'auth' xml



On Mon, Oct 12, 2009 at 10:46:48AM -0400, Cole Robinson wrote:
> We were missing a closing tag, so the XML wasn't proper.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/conf/storage_conf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
> index 788de15..1633aac 100644
> --- a/src/conf/storage_conf.c
> +++ b/src/conf/storage_conf.c
> @@ -799,7 +799,7 @@ virStoragePoolSourceFormat(virConnectPtr conn,
>  
>  
>      if (src->authType == VIR_STORAGE_POOL_AUTH_CHAP)
> -        virBufferVSprintf(buf,"    <auth type='chap' login='%s' passwd='%s'>\n",
> +        virBufferVSprintf(buf,"    <auth type='chap' login='%s' passwd='%s'/>\n",
>                            src->auth.chap.login,
>                            src->auth.chap.passwd);
>      virBufferAddLit(buf,"  </source>\n");

  ACK !
  Could you please push this now ?

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]