[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/10] tests: More XML 2 XML tests and cleanups

On Mon, Oct 12, 2009 at 10:45:05AM -0400, Cole Robinson wrote:
> In attempting to refactor some storage pool XML parsing, I wanted some unit
> tests to ensure I wasn't causing regressions. So, the following series adds
> XML 2 XML tests for storage pools (and virtual networks and storage vols).
> Also included are several cleanups in tests/, and bug fixes needed to make
> the new tests actually pass.
> Cole Robinson (10):
>   tests: Fix text output for interface XML 2 XML
>   tests: Document VIR_TEST_DEBUG environment variable.
>   tests: Break out duplicate schema verification functionality.
>   storage: Fix generating iscsi 'auth' xml
>   schema: Update storage pool schema.
>   tests: Add XML 2 XML tests for storage pools.
>   network: Fix reading 'forwardDelay' attribute.
>   schema: Update network schema.
>   tests: Add network XML to XML tests.
>   tests: Add storage volume XML 2 XML tests.

  I'm fine with the overall test cleanup. I would prefer if the few
real bug fixes in the lot could be fixed now for 0.7.2 release, if you
want to commit the changes to test/ I'm fine too since that should not
affect running code (just make sure 'make dist' still passes after it ;-)

  thanks !


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]