[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/10] tests: Break out duplicate schema verification functionality.



Matthias Bolte wrote:
> 2009/10/12 Cole Robinson <crobinso redhat com>:
>> All schema tests have identical functionality, so avoid the duplication.
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
>> ---
>>  tests/Makefile.am           |    1 +
>>  tests/capabilityschematest  |   34 ++++------------------------------
>>  tests/domainschematest      |   33 ++++-----------------------------
>>  tests/interfaceschematest   |   31 +++----------------------------
>>  tests/networkschematest     |   30 +++---------------------------
>>  tests/nodedevschematest     |   31 +++----------------------------
>>  tests/schematestutils.sh    |   39 +++++++++++++++++++++++++++++++++++++++
>> Â tests/storagepoolschematest | Â  31 +++----------------------------
>>  tests/storagevolschematest  |   30 +++---------------------------
>> Â 9 files changed, 63 insertions(+), 197 deletions(-)
>> Â create mode 100644 tests/schematestutils.sh
> 
> Your patch adds some bashisms. This prevents make check from running
> successfully on Debian/Ubuntu, because their default shell is dash and
> not bash.
> 
> The attached patch removes this bashisms.
> 
> Matthias
> 

Ah, I meant to check for that, I've made the same mistake in the past.

ACK to the patch.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]