[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Centralize VIR_TEST_DEBUG lookup, and document it



On 10/19/2009 10:38 AM, Cole Robinson wrote:
> On 10/17/2009 08:03 AM, Matthias Bolte wrote:
>> 2009/10/16 Cole Robinson <crobinso redhat com>:
>>> Provide a simple interface for other tests to lookup the testDebug variable.
>>> Also remove a redundant error message in interface tests.
>>>
>>> If anyone feels inclined to change this env variable to match the existing
>>> LIBVIRT_* format, it should now be easier to do so.
>>>
>>> Signed-off-by: Cole Robinson <crobinso redhat com>
>>> ---
>>> Â HACKING Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â | Â  10 ++++++++++
>>> Â tests/interfacexml2xmltest.c | Â  Â 2 --
>>>  tests/statstest.c            |    4 ++--
>>>  tests/testutils.c            |   38 ++++++++++++++++++++++++++------------
>>>  tests/testutils.h            |    4 ++--
>>>  tests/testutilsqemu.c        |    2 +-
>>> Â 6 files changed, 41 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/HACKING b/HACKING
>>> index bcff8c6..fba7778 100644
>>> --- a/HACKING
>>> +++ b/HACKING
>>> @@ -37,6 +37,16 @@ and run the tests:
>>>
>>> Â The latter test checks for memory leaks.
>>>
>>> +If you encounter any failing tests, the VIR_TEST_DEBUG environment variable
>>> +may help:
>>> +
>>> +  VIR_TEST_DEBUG=1 make check    (or)
>>> + Â VIR_TEST_DEBUG=2 make check
>>
>> Maybe explain what VIR_TEST_DEBUG actually does and what's the
>> difference between 1 and 2.
>>
> 
> Yes, this wording can be improved, I will fix it and repost.
> 

Actually, I just pushed this patch with the 'static' fix and the
following updated wording:

If you encounter any failing tests, the VIR_TEST_DEBUG environment
variable may provide extra information to debug the failures. Larger
values of VIR_TEST_DEBUG may provide larger amounts of information:

  VIR_TEST_DEBUG=1 make check    (or)
  VIR_TEST_DEBUG=2 make check

Didn't think it was really major enough to warrant a second posting.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]