[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/11] tests: Add network XML to XML tests.



On 10/21/2009 05:18 AM, Daniel Veillard wrote:
>   Cole, I'm afraid you broke the dist when making this commit
> 
> On Mon, Oct 12, 2009 at 10:46:54AM -0400, Cole Robinson wrote:
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
>> ---
> [...]
>>  create mode 100644 tests/networkxml2xmlin/forward-delay-network.xml
>>  create mode 100644 tests/networkxml2xmlin/isolated-network.xml
>>  create mode 100644 tests/networkxml2xmlin/nat-network.xml
>>  create mode 100644 tests/networkxml2xmlin/netboot-network.xml
>>  create mode 100644 tests/networkxml2xmlin/routed-network.xml
>>  create mode 100644 tests/networkxml2xmlout/forward-delay-network.xml
>>  create mode 100644 tests/networkxml2xmlout/isolated-network.xml
>>  create mode 100644 tests/networkxml2xmlout/nat-network.xml
>>  create mode 100644 tests/networkxml2xmlout/netboot-network.xml
>>  create mode 100644 tests/networkxml2xmlout/routed-network.xml
>>  create mode 100644 tests/networkxml2xmltest.c
> 
>   All files are created in tests/networkxml2xmlin and
>   tests/networkxml2xmlout
> 
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -56,7 +56,8 @@ EXTRA_DIST =		\
>>  	capabilityschematest \
>>  	capabilityschemadata \
>>  	networkschematest \
>> -	networkschemadata \
>> +	networkpoolxml2xmlout \
>> +	networkpoolxml2xmlin \
> 
>   But here you use the wrong paths
> Clearly 'pool' need to be removed from those subdirs, I commited
> that fix to restore make dist/make rpm
> 
> Daniel
> 

Arg, my bad. Pretty sure I fixed that at one point but must have rebased
incorrectly. Thanks for the fix up.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]