[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Tighten up nonreentrant syntax-check.



Cole Robinson wrote:
> On 10/23/2009 07:01 AM, Chris Lalancette wrote:
>> We can slightly tighten up the regex's used to detect the use of
>> nonreentrant functions.  We can also check src/util/virterror.c
>> by modifying a comment; I think it's worth it to get the additional
>> coverage.
>>
>> Signed-off-by: Chris Lalancette <clalance redhat com>
>> ---
>>  .x-sc_prohibit_nonreentrant |    8 ++++----
>>  src/util/virterror.c        |    2 +-
>>  2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/.x-sc_prohibit_nonreentrant b/.x-sc_prohibit_nonreentrant
>> index ac783c0..0ab2f5d 100644
>> --- a/.x-sc_prohibit_nonreentrant
>> +++ b/.x-sc_prohibit_nonreentrant
>> @@ -1,10 +1,10 @@
>>  ^gnulib/
>>  ^po/
>> -ChangeLog
>> +^ChangeLog$
>> +^ChangeLog-old$
>>  ^Makefile*
>>  ^docs/
>>  ^tests/
>> -^tools/virsh\.c
>> -^tools/console\.c
>> -^src/util/virterror\.c
>> +^tools/virsh\.c$
>> +^tools/console\.c$
>>  ^build-aux/
>> diff --git a/src/util/virterror.c b/src/util/virterror.c
>> index e421ab7..657cb3f 100644
>> --- a/src/util/virterror.c
>> +++ b/src/util/virterror.c
>> @@ -1157,7 +1157,7 @@ const char *virStrerror(int theerrno, char *errBuf, size_t errBufLen)
>>      return errBuf;
>>  # endif
>>  #else
>> -    /* Mingw lacks strerror_r() and its strerror() is definitely not
>> +    /* Mingw lacks strerror_r and its strerror is definitely not
>>       * threadsafe, so safest option is to just print the raw errno
>>       * value - we can at least reliably & safely look it up in the
>>       * header files for debug purposes
> 
> ACK

Thanks, committed.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]