[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 19/21] Start of support for QEMU JSON based monitor protocol



On Mon, Oct 26, 2009 at 11:15:22AM +0100, Paolo Bonzini wrote:
> On 10/23/2009 03:05 PM, Daniel P. Berrange wrote:
> >+    if (mon->json)
> >+        ret = qemuMonitorJSONSystemPowerdown(mon);
> >+    else
> >+        ret = qemuMonitorTextSystemPowerdown(mon);
> 
> Why not make a vtable?

We're not expecting to grow any more different protocol implementations,
so I don't think it is a worthwhile tradeoff to introduce an extra
layer of indirection into the code.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]