[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Support reporting live interface IP/netmask.

On Fri, Oct 16, 2009 at 10:56:18AM -0400, laine laine org wrote:
> From: Laine Stump <laine laine org>
> This patch adds the flag VIR_INTERFACE_XML_INACTIVE to
> virInterfaceGetXMLDesc's flags. When it is*not* set (the default), the
> live interface info will be returned in the XML (in particular, the IP
> address(es) and netmask(s) will be retrieved by querying the interface
> directly, rather than  reporting what's in the config file). The
> backend of this is in netcf's ncf_if_xml_state() function.

  Okay, looks fine, applied.

> Note that after this patch is applied, netcf support will be omitted
> from the build unless you have netcf-devel-0.1.3 or better installed.

  yup, it's not worth messing the code to handle older releases at this
point I guess. The only problem will be with people using F-12 or
versions based on netcf 0.1.x x < 3 willing to recompile a newer version
and loosing the interface functionality.


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]