[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] (REVISED) Support for IPv6 / multiple addresses per interface in virInterface



On Wed, Oct 28, 2009 at 02:25:38PM +0100, Daniel Veillard wrote:
> On Wed, Oct 28, 2009 at 12:06:24PM +0100, Daniel Veillard wrote:
> [...]
> > But the main problem I faced when running the regression tests.
> > I had installed netcf-0.1.3 and a number of thing just break with
> > this patch. For example when libvirtd exits in the 
> >   "testing with corrupted config" libvirtd it just segfaults:
> > 
> > Starting program: /u/veillard/libvirt/daemon/libvirtd --config=in1.conf
> > [...]
> > Program received signal SIGSEGV, Segmentation fault.
> > drv_close (ncf=0x7f0740) at drv_initscripts.c:511
> > 511     xsltFreeStylesheet(ncf->driver->get);
> > (gdb) p ncf->driver
> > $2 = (struct driver *) 0x0
> > (gdb) p *ncf
> > $3 = {ref = 1, root = 0x7f0780 "/", 
> >   data_dir = 0x7ffff77626b8 "/usr/share/netcf", errcode = NETCF_NOERROR, 
> >   errdetails = 0x0, driver = 0x0, debug = 0}
> > (gdb) 
> 
>   Okay, I modified netcf to incorporate the patch below to avoid the
> crash, but I still get a ton of regression tests failures on F-11 +

  urgh, forgot it :-\

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/
--- src/netcf.c.orig	2009-10-28 14:05:51.000000000 +0100
+++ src/netcf.c	2009-10-28 14:06:00.000000000 +0100
@@ -111,7 +111,8 @@ int ncf_close(struct netcf *ncf) {
 
     ERR_COND_BAIL(ncf->ref > 1, ncf, EINUSE);
 
-    drv_close(ncf);
+    if (ncf->driver != NULL)
+        drv_close(ncf);
     unref(ncf, netcf);
     return 0;
  error:

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]