[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] storage: Break out pool source parsing to a separate function.



On Fri, Oct 16, 2009 at 12:35:11PM -0400, Cole Robinson wrote:
> We need to parse a source XML block for FindPoolSources, so this is a step
> in sharing the parsing. The new storage pool XML 2 XML tests cover this area
> pretty well to ensure we aren't causing regressions.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>

  Refactoring looks fine to me, it seems changing the context node is
fine as it's properly restaured and XPath expressions are changed to
be made relative to the new node.

  ACK, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]