[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] test: Support virStorageFindPoolSources



On Fri, Oct 16, 2009 at 12:35:14PM -0400, Cole Robinson wrote:
> The results are hardcoded into the test driver, no option to read from a
> testfile is implemented at this time.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/test/test_driver.c |   75 +++++++++++++++++++++++++++++++++++++++++++++--
>  1 files changed, 71 insertions(+), 4 deletions(-)

  ACK, that's a good first step.
Out of curiosity did you check make valgrind for leaks ?

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]