[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/20] Provide missing passphrase when creating a volume.



----- "Daniel P. Berrange" <berrange redhat com> wrote:
> > > I reckon this snippet of code could usefully be put into the util.h file
> > > as virFileGenerateRandomkey(), or alternatively perhaps secret_conf.h, 
> > > as virSecretGenerateRandomKey(unsigned char *buf, size_t buflen);
> > This code, with its limitation to ASCII characters, is
> qcow/qemu-specific.
> 
> Ok, lets leave it in the QEMU driver file then
AFAICS the qemu and storage drivers can be built as modules, this would create a dependency.  I'll just split the code into a separate function for now.
    Mirek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]