[libvirt] [PATCH 3/6] Port QEMU driver to use USB/PCI device helpers
Daniel Veillard
veillard at redhat.com
Wed Sep 2 09:20:20 UTC 2009
On Tue, Sep 01, 2009 at 04:28:56PM +0100, Daniel P. Berrange wrote:
> * src/qemu_driver.c: Remove usbfs/sysfs iterator code and call
> into generic helper APIs instead when setting device permissions
Yup, nice cleanup, ACK,
just one thing, it would be good in 1/6 and 2/6 to detail as a comment
on the iterators in the headers the expected return value and the fact
that non-zero will break iteration and be the returned value from top
level. Usually when having to program those callbacks it's the classic
pitfall :)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list