[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Added Storage Volume support to VIrtualBox



On Thu, Sep 03, 2009 at 05:55:53PM +0200, Pritesh Kothari wrote:
> Hi All,
> 
> I have added support for Storage Volumes in VirtualBox, the patch for the same 
> is attached here.
> 
> (needs the "little bit cleanup" patch previously posted)

  Looks fine, to the extend that I understand the code (clearly not all
of it).  The very long lines over 80 chars really makes it far less
readable for me too. At some point it would be nice to fix this.

My own formatter is the following command using gnu indent:

paphio:~/libvirt -> cat ~/bin/cb
#!/bin/sh
indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l75 -lc75 -nut -sbi4 \
-psl -saf -sai -saw -sbi4 -ss -sc -cdw -cli4 -npcs -nbc

  In any case, applied and commited,

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]