[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/7] VMware ESX: Add esxGetCapabilities() with basic default capabilities



2009/9/4 Daniel Veillard <veillard redhat com>:
> On Thu, Sep 03, 2009 at 06:45:44PM +0200, Matthias Bolte wrote:
>> * src/esx/esx_driver.c: add esxCapsInit() with default caps and add
>>   esxGetCapabilities()
>
>  Hum ... That one looks really incomplete. Does it really make sense
> to implement it just based on pure default without asking the ESX
> about it's capabilities ?
>  I think it should be applied because of the MAC prefix and
> AddHostMigrateTransport hints but the capabilities themselves look a bit
> misleading.
>
>   I'm applying but it really seems this need more work, right ? ;-)

Yes, this is incomplete. I've a patch that adds x86_64 vs. i686
detection based on the CPUID. I also have patches for VMX to domain
XML mapping including a bunch of test for VMX <-> domain XML mapping,
but they need some cleanup before I'll post them.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]